Add label to webextension add-ons on their detail page #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
commented
Apr 11, 2017
| @@ -563,14 +569,10 @@ def process_comment(self): | |||
| self.version.update(**kw) | |||
| self.log_action(amo.LOG.COMMENT_VERSION) | |||
|
|
|||
|
|
|||
| class ReviewAddon(ReviewBase): | |||
EnTeQuAk
reviewed
Apr 11, 2017
| """Add firefox57 tag to addons with the specified ids.""" | ||
| log.info( | ||
| 'Adding firefox57 tag to addons %d-%d [%d].', | ||
| ids[0], ids[-1], len(ids)) |
There was a problem hiding this comment.
nitpick, if ids is empty this could raise an IndexError
EnTeQuAk
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in the issue, also add a tag to those add-ons to be able to filter them in search.
Fix mozilla/addons#4167